[webkit-reviews] review granted: [Bug 192496] Enable DFG on ARM/Linux again : [Attachment 358603] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 192496: Enable DFG on ARM/Linux again
https://bugs.webkit.org/show_bug.cgi?id=192496

Attachment 358603: Patch

https://bugs.webkit.org/attachment.cgi?id=358603&action=review




--- Comment #12 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 358603
  --> https://bugs.webkit.org/attachment.cgi?id=358603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358603&action=review

r=me with nits.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:142
> +	       // FIXME: support callee-saved floating point registers on
32-bit architectures

Please file a bug with FIXME and add a url here.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:172
> +	       // FIXME: support callee-saved floating point registers on
32-bit architectures

Ditto.

> Source/JavaScriptCore/jit/GPRInfo.h:529
>  #if CPU(ARM)

I think we should use #if CPU(ARM_THUMB2) here since the following information
is not correct for CPU(ARM) from now.