[webkit-reviews] review denied: [Bug 192391] Use directory local sequential numbers for Unified Sources filenames instead of global sequential numbers for CMake : [Attachment 358091] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192391: Use directory local sequential numbers for Unified Sources
filenames instead of global sequential numbers for CMake
https://bugs.webkit.org/show_bug.cgi?id=192391

Attachment 358091: Patch

https://bugs.webkit.org/attachment.cgi?id=358091&action=review




--- Comment #22 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 358091
  --> https://bugs.webkit.org/attachment.cgi?id=358091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358091&action=review

>> Source/WTF/Scripts/generate-unified-source-bundles.rb:214
>> +		    "-#{hash}-#{@bundleCountInDirectory}"
> 
> It feels a bit strange that the bundleFileName(number) function by its
signature would seem to be something that would generate a distinct filename
when called with different numbers, but won't actually do so when maxCount
isn't set without external help (like changing bundleCountInDirectory). It's
not a big deal, but could be confusing.

Good point. Will fix.