[webkit-reviews] review granted: [Bug 193207] Remove use of NetworkProcess::singleton for downloads : [Attachment 358524] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193207: Remove use of NetworkProcess::singleton for downloads
https://bugs.webkit.org/show_bug.cgi?id=193207

Attachment 358524: Patch

https://bugs.webkit.org/attachment.cgi?id=358524&action=review




--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 358524
  --> https://bugs.webkit.org/attachment.cgi?id=358524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358524&action=review

> Source/WebKit/NetworkProcess/Downloads/PendingDownload.h:51
> +    PendingDownload(IPC::Connection*, NetworkLoadParameters&&, DownloadID,
NetworkSession&, const String& suggestedName);
> +    PendingDownload(IPC::Connection*, std::unique_ptr<NetworkLoad>&&,
ResponseCompletionHandler&&, DownloadID, const WebCore::ResourceRequest&, const
WebCore::ResourceResponse&);

Sure wish we could make these take Connection&