[webkit-reviews] review granted: [Bug 193204] Web Inspector: Remote inspector can crash if attempting to navigate inspector page : [Attachment 358512] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 193204: Web Inspector: Remote inspector can crash if attempting to navigate
inspector page
https://bugs.webkit.org/show_bug.cgi?id=193204

Attachment 358512: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=358512&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358512
  --> https://bugs.webkit.org/attachment.cgi?id=358512
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=358512&action=review

rs=me, never a bad idea to add a nullptr check 😁

> Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm:88
> +    m_inspectorView = adoptNS([[WKInspectorViewController alloc]
initWithInspectedPage:nullptr]);

Just for my knowledge, is it preferred to use `nil` or `nullptr` in ObjC code?
Is `nullptr` preferred here because the value expected by
`initWithInspectedPage` is a `WebPageProxy`, which is a C++ object, or am I
just overthinking things?