[webkit-reviews] review granted: [Bug 193188] Deactivate audio session whenever possible : [Attachment 358504] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 193188: Deactivate audio session whenever possible
https://bugs.webkit.org/show_bug.cgi?id=193188

Attachment 358504: Patch

https://bugs.webkit.org/attachment.cgi?id=358504&action=review




--- Comment #7 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 358504
  --> https://bugs.webkit.org/attachment.cgi?id=358504
Patch

r=me, with the nit that this area of the code needs some refactoring. We should
investigate making it cheaper to access
PlatformMediaSessionManager::sharedManager() when no sessions exist yet and
move these global settings (and other DeprecatedGlobalSettings) directly into
the PlatformMediaSessionManager itself.