[webkit-reviews] review granted: [Bug 193195] [Web Animations] Audit Web Animations classes for memory reduction : [Attachment 358494] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 193195: [Web Animations] Audit Web Animations classes for memory reduction
https://bugs.webkit.org/show_bug.cgi?id=193195

Attachment 358494: Patch

https://bugs.webkit.org/attachment.cgi?id=358494&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 358494
  --> https://bugs.webkit.org/attachment.cgi?id=358494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358494&action=review

> Source/WebCore/animation/ComputedEffectTiming.h:36
>      Optional<double> localTime;
>      Optional<double> progress;
>      Optional<double> currentIteration;

Can these be Markable<>?

> Source/WebCore/animation/OptionalEffectTiming.h:40
>      Optional<double> delay;
>      Optional<double> endDelay;
> -    Optional<FillMode> fill;
>      Optional<double> iterationStart;
>      Optional<double> iterations;

Can these be Markable<>?

> Source/WebCore/animation/OptionalEffectTiming.h:41
>      String easing;

What is this String for? Could it be an enum here?

> Source/WebCore/animation/OptionalEffectTiming.h:43
> +    Optional<FillMode> fill;
> +    Optional<PlaybackDirection> direction;

Can these be Markable<>?