[webkit-reviews] review granted: [Bug 185843] Web Inspector: extend XHR breakpoints to work with fetch : [Attachment 358471] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 185843: Web Inspector: extend XHR breakpoints to work with fetch
https://bugs.webkit.org/show_bug.cgi?id=185843

Attachment 358471: Patch

https://bugs.webkit.org/attachment.cgi?id=358471&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 358471
  --> https://bugs.webkit.org/attachment.cgi?id=358471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358471&action=review

r=me, nice refactoring. I think we should combine fetch-breakpoints.html and
xhr-breakpoints.html, since the files are nearly identical.

> Source/WebInspectorUI/UserInterface/Models/URLBreakpoint.js:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2019

> Source/WebInspectorUI/UserInterface/Views/URLBreakpointPopover.css:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

Ditto for all these copy-pasted files.

> LayoutTests/inspector/dom-debugger/fetch-breakpoints-expected.txt:19
> +Sending Fetch.

Nit: logging the URL improves the clarity of tests that that URL matches a
string/regular expression.

Sending Fetch -> Fetch "dataFetch.json"