[webkit-reviews] review granted: [Bug 193156] A MediaTime timescale must never be zero : [Attachment 358442] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 193156: A MediaTime timescale must never be zero
https://bugs.webkit.org/show_bug.cgi?id=193156

Attachment 358442: Patch

https://bugs.webkit.org/attachment.cgi?id=358442&action=review




--- Comment #13 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 358442
  --> https://bugs.webkit.org/attachment.cgi?id=358442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358442&action=review

r=me with nit:

> Source/WTF/wtf/MediaTime.cpp:90
> +    if (value < 0)
> +	   *this = negativeInfiniteTime();
> +    else
> +	   *this = positiveInfiniteTime();

Nit: in other places you use a ternary operator for this kind of thing.