[webkit-reviews] review requested: [Bug 193149] Web Inspector: Audit: create new IDL type for exposing special functionality in test context : [Attachment 358462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 11:14:22 PST 2019


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 193149: Web Inspector: Audit: create new IDL type for exposing special
functionality in test context
https://bugs.webkit.org/show_bug.cgi?id=193149

Attachment 358462: Patch

https://bugs.webkit.org/attachment.cgi?id=358462&action=review




--- Comment #22 from Devin Rousso <drousso at apple.com> ---
Created attachment 358462

  --> https://bugs.webkit.org/attachment.cgi?id=358462&action=review

Patch

Rework the injected `AUDIT` object to be a plain JavaScript object with special
IDL subobjects.  This way, we can always provide an `AUDIT` object, and can
call the `AuditAgent` functions in such an order as to preserve the `AUDIT`
object between tests, allowing for a simple way to share values between runs.


More information about the webkit-reviews mailing list