[webkit-reviews] review granted: [Bug 193154] Leak of two CCRSACryptorRef (4.0 Kbytes/1 page each) in com.apple.WebKit.WebContent running WebKit layout tests : [Attachment 358435] Patch v6

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 193154: Leak of two CCRSACryptorRef (4.0 Kbytes/1 page each) in
com.apple.WebKit.WebContent running WebKit layout tests
https://bugs.webkit.org/show_bug.cgi?id=193154

Attachment 358435: Patch v6

https://bugs.webkit.org/attachment.cgi?id=358435&action=review




--- Comment #16 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 358435
  --> https://bugs.webkit.org/attachment.cgi?id=358435
Patch v6

View in context: https://bugs.webkit.org/attachment.cgi?id=358435&action=review

Looks good.

> Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:73
> +    CCCryptorStatus status = CCRSAGetKeyComponents(keyIsPublic ?
rsaKey.get() : publicKeyFromPrivateKey.get(), modulus.data(), &modulusLength,
publicExponent.data(), &exponentLength, 0, 0, 0, 0);

Nice!