[webkit-reviews] review granted: [Bug 193172] Incorrect clipping across compositing boundary. : [Attachment 358443] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 193172: Incorrect clipping across compositing boundary.
https://bugs.webkit.org/show_bug.cgi?id=193172

Attachment 358443: Patch

https://bugs.webkit.org/attachment.cgi?id=358443&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 358443
  --> https://bugs.webkit.org/attachment.cgi?id=358443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358443&action=review

> Source/WebCore/ChangeLog:12
> +	   clip rect update using the wrong painting root. This happens when
the layer hierarchy and the compositing contex do not match.

contex

> Source/WebCore/rendering/RenderLayer.cpp:5486
> +	   auto paginationBoundary =
parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) !=
enclosingPaginationLayer(IncludeCompositedPaginatedLayers);
> +	   auto compositionBoundaryForRepaint =
parent()->enclosingCompositingLayerForRepaint() !=
enclosingCompositingLayerForRepaint();

I hate auto for primitive types like bool. It doesn't save typing, and it's
very unlikely that you'd ever refactor and change the type to get the benefit
of auto.

Here, reading "auto paginationBoundary" makes me think that there's some
complex "boundary" type I have to go look for.

These bools would read better as crossesPaginationBoundary,
crossesCompositingBoundary.