[webkit-reviews] review granted: [Bug 193164] Modernize CacheModel and disk cache fetching and clearing : [Attachment 358412] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193164: Modernize CacheModel and disk cache fetching and clearing
https://bugs.webkit.org/show_bug.cgi?id=193164

Attachment 358412: Patch

https://bugs.webkit.org/attachment.cgi?id=358412&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358412
  --> https://bugs.webkit.org/attachment.cgi?id=358412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358412&action=review

r=me, but it looks like 1 important issue to fix

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:577
> +    auto* cache = NetworkProcess::singleton().cache();
> +    if (!cache) {
> +	   RunLoop::main().dispatch([completionHandler =
WTFMove(completionHandler)] () mutable {
> +	       completionHandler({ });
> +	   });
> +    }

You will need to return here or else you will crash by dereferencing `cache`
later on.