[webkit-reviews] review granted: [Bug 193158] Web Inspector: Audit: disable breakpoints when running Audit : [Attachment 358367] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193158: Web Inspector: Audit: disable breakpoints when running Audit
https://bugs.webkit.org/show_bug.cgi?id=193158

Attachment 358367: Patch

https://bugs.webkit.org/attachment.cgi?id=358367&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358367
  --> https://bugs.webkit.org/attachment.cgi?id=358367
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358367&action=review

r=me

> Source/WebInspectorUI/ChangeLog:3
> +	   Web Inspector: Audit: disable breakpoints when running Audit

Should we include a test that a `debugger` statement doesn't cause a pause when
the audit runs?

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1162
> +    _handleAuditManagerTestScheduled(event)
> +    {
> +	   this._startDisablingBreakpointsTemporarily();
> +
> +	   if (this.paused)
> +	       this.resume();
> +    }
> +
> +    _handleAuditManagerTestCompleted(event)
> +    {
> +	   this._stopDisablingBreakpointsTemporarily();
> +    }
> +

We may need start/stop to be counters / enums. Someone could technically
attempt to start/stop a Timeline profile during audits and then the debugger
would be enabled during any remaining audits.