[webkit-reviews] review granted: [Bug 193140] [ews-build] Add build step to validate the patch before processing it : [Attachment 358345] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 12:41:17 PST 2019
Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 193140: [ews-build] Add build step to validate the patch before processing
it
https://bugs.webkit.org/show_bug.cgi?id=193140
Attachment 358345: Updated patch
https://bugs.webkit.org/attachment.cgi?id=358345&action=review
--- Comment #7 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 358345
--> https://bugs.webkit.org/attachment.cgi?id=358345
Updated patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358345&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:263
> + self._addToLog('stdio', 'Fetched Patch id {} does not match with
requested patch id {}. Unable to validate.\n'.format(patch_json.get('id'),
self.getProperty('patch_id', '')))
nit: lowercase 'patch'
More information about the webkit-reviews
mailing list