[webkit-reviews] review granted: [Bug 193148] Web Inspector: Add a Setting Toggle for Source Maps : [Attachment 358338] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 193148: Web Inspector: Add a Setting Toggle for Source Maps
https://bugs.webkit.org/show_bug.cgi?id=193148

Attachment 358338: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=358338&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358338
  --> https://bugs.webkit.org/attachment.cgi?id=358338
[PATCH] Proposed Fix

r=me, should we add a `console.assert(WI.settings.sourceMapsEnabled.value)`
inside `WI.SourceMap` somewhere, for sanity's sake?  Do we want to do anything
for the case where the user disables source maps after having already
downloaded and shown them (e.g. in Resources)?