[webkit-reviews] review granted: [Bug 193125] Resync WPT fetch tests to 834eac4 : [Attachment 358306] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 193125: Resync WPT fetch tests to 834eac4
https://bugs.webkit.org/show_bug.cgi?id=193125

Attachment 358306: Patch

https://bugs.webkit.org/attachment.cgi?id=358306&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 358306
  --> https://bugs.webkit.org/attachment.cgi?id=358306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358306&action=review

>
LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/keepalive-expected.
txt:3
> +Harness Error (TIMEOUT), message = null

This test should be skipped since it times out. Otherwise, layout tests running
time will significantly increase.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/api/idl.any.worker-expected.t
xt:2
> +FAIL idl_test setup promise_test: Unhandled rejection with value: object
"Got an error before parsing any named definition: Unrecognised tokens, line 1
(tokens: "{\"error\": {\"message\"")

Looks like this test could be failing simply because you failed to import
referrer-policy.idl in LayoutTests/imported/w3c/web-platform-tests/interfaces/

>
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/destination/fetch
-destination-prefetch.https-expected.txt:2
> +Harness Error (TIMEOUT), message = null

This test should be skipped.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-keepalive
-quota-expected.txt:1
> +CONSOLE MESSAGE: line 45: ReferenceError: Can't find variable:
subsetTestByKey

This looks like an import problem, not a legit test failure, please take a
look. We may be missing /common/subset-tests-by-key.js

>
LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-
with-broken-then.any.worker-expected.txt:2
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-bod
y.any.worker-expected.txt:2
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/content-type/response.window-
expected.txt:2
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/corb/preload-image-png-mislab
eled-as-html-nosniff.tentative.sub-expected.txt:4
> +Harness Error (TIMEOUT), message = null

Please Skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/corb/script-html-correctly-la
beled.tentative.sub-expected.txt:3
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/corb/script-html-js-polyglot.
sub-expected.txt:4
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/corb/script-html-via-cross-or
igin-blob-url.sub-expected.txt:3
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/range/sw.https.window-expecte
d.txt:1
> +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 73757)

Please make sure it is skipped.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/embed.tentative.
https.sub-expected.txt:3
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/iframe.tentative
.https.sub-expected.txt:5
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/object.tentative
.https.sub-expected.txt:3
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/redirect/multipl
e-redirect-cross-site.tentative.https.sub-expected.txt:4
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/redirect/multipl
e-redirect-same-site.tentative.https.sub-expected.txt:4
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/redirect/same-or
igin-redirect.tentative.https.sub-expected.txt:4
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/track.tentative.
https.sub-expected.txt:3
> +Harness Error (TIMEOUT), message = null

Please skip.

>
LayoutTests/imported/w3c/web-platform-tests/fetch/sec-metadata/window-open.tent
ative.https.sub-expected.txt:5
> +Harness Error (TIMEOUT), message = null

Please skip.