[webkit-reviews] review granted: [Bug 174980] [Fetch API] Implement abortable fetch : [Attachment 358267] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 174980: [Fetch API] Implement abortable fetch
https://bugs.webkit.org/show_bug.cgi?id=174980

Attachment 358267: Patch

https://bugs.webkit.org/attachment.cgi?id=358267&action=review




--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 358267
  --> https://bugs.webkit.org/attachment.cgi?id=358267
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358267&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.h:130
> +    struct LoadingError {

Can you really have both a ResourceError and an exception at the same time. If
not, could we use a Variant instead?