[webkit-reviews] review granted: [Bug 193105] Progress towards fixing Mac CMake build : [Attachment 358254] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193105: Progress towards fixing Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=193105

Attachment 358254: Patch

https://bugs.webkit.org/attachment.cgi?id=358254&action=review




--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 358254
  --> https://bugs.webkit.org/attachment.cgi?id=358254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358254&action=review

r=me contingent on the build passing :)

> Source/WebCore/Modules/indexeddb/shared/IDBError.h:31
> -#include "DOMException.h"
>  #include "ExceptionCode.h"
> +#include <WebCore/DOMException.h>

This shouldn't have been changed and looks to be part of the build breakage.

> Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h:31
> +#include "GPURenderPipeline.h"

GPURenderPipeline is forward declared in this file so either remove this or
remove the declaration.