[webkit-reviews] review granted: [Bug 189302] REGRESSION: -webkit-appearance test case crashes : [Attachment 358278] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 3 14:38:19 PST 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 189302: REGRESSION: -webkit-appearance test case crashes
https://bugs.webkit.org/show_bug.cgi?id=189302
Attachment 358278: Patch
https://bugs.webkit.org/attachment.cgi?id=358278&action=review
--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 358278
--> https://bugs.webkit.org/attachment.cgi?id=358278
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358278&action=review
> Source/WebCore/rendering/RenderThemeMac.mm:2080
> + // Set horizontal position back to based on the content direction
(cancelButtonRectForBounds() only knows about system direction).
Nit - I think you missed a word in "…back to based on the…"
More information about the webkit-reviews
mailing list