[webkit-reviews] review denied: [Bug 193098] Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover : [Attachment 358237] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 193098: Web Inspector: Styles: pressing Down key on empty value field
shouldn't discard completion popover
https://bugs.webkit.org/show_bug.cgi?id=193098

Attachment 358237: Patch

https://bugs.webkit.org/attachment.cgi?id=358237&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358237
  --> https://bugs.webkit.org/attachment.cgi?id=358237
Patch

r-, as this doesn't work if the completion causes a wrapping to the next line:

1. inspect <https://webkit.org>
2. show the Elements tab
3. make the Styles sidebar as small (width) as possible
4. add a new property with "-apple-pay-button-style" as the name
5. tab to the value editor
6. press down
 => the "black" value causes the property to wrap, which hides the suggestions
list

Rather than try to calculate the position of the caret, perhaps we can use a
capturing "scroll" listener on the document/window that checks to see if the
target is an ancestor of the suggestions view, and if so removes the listener
and hides the suggestions view.  This would prevent other hide triggers (e.g.
resizing the Styles sidebar while the suggestions view is showing causes it to
hide if the property no longer wraps) and simplify the logic (albeit at the
"expense" of a capturing event listener).