[webkit-reviews] review granted: [Bug 193094] DFG IntegerRangeOptimization phase exceeding loop limit shouldn't ASSERT : [Attachment 358230] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 19:17:29 PST 2019


Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 193094: DFG IntegerRangeOptimization phase exceeding loop limit shouldn't
ASSERT
https://bugs.webkit.org/show_bug.cgi?id=193094

Attachment 358230: Patch

https://bugs.webkit.org/attachment.cgi?id=358230&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 358230
  --> https://bugs.webkit.org/attachment.cgi?id=358230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358230&action=review

> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1098
>		   // If you hit this assertion for a legitimate case, update
the giveUpThreshold
>		   // to the smallest values that converges.

There is no more assertion.


More information about the webkit-reviews mailing list