[webkit-reviews] review granted: [Bug 193034] Add support for using the current text selection as the find string on iOS : [Attachment 358099] Patch v2 (fix macOS 10.12 builds)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 11:17:55 PST 2019


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 193034: Add support for using the current text selection as the find string
on iOS
https://bugs.webkit.org/show_bug.cgi?id=193034

Attachment 358099: Patch v2 (fix macOS 10.12 builds)

https://bugs.webkit.org/attachment.cgi?id=358099&action=review




--- Comment #12 from Tim Horton <thorton at apple.com> ---
Comment on attachment 358099
  --> https://bugs.webkit.org/attachment.cgi?id=358099
Patch v2 (fix macOS 10.12 builds)

This patch introduces the first (and first bunch) of the use of the phrase
"find in page" in actual code (vs. tests and changelog entries). Other SPI just
calls it "find". I wonder if this patch should follow suit.


More information about the webkit-reviews mailing list