[webkit-reviews] review granted: [Bug 195121] Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction : [Attachment 363173] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 14:46:49 PST 2019


Alex Christensen <achristensen at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 195121: Expose APINavigationAction.shouldPerformDownload() on
WKNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=195121

Attachment 363173: Patch v4

https://bugs.webkit.org/attachment.cgi?id=363173&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 363173
  --> https://bugs.webkit.org/attachment.cgi?id=363173
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=363173&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:97
> +    auto baseURL = adoptNS([[NSURL alloc]
initWithString:@"https://example.com/index.html"]);

This is a little simpler:
[NSURL URLWithString:@"https://example.com/index.html"]


More information about the webkit-reviews mailing list