[webkit-reviews] review granted: [Bug 194437] REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout : [Attachment 363171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 14:20:41 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 194437: REGRESSION (r240644): Layout Test
inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky
timeout
https://bugs.webkit.org/show_bug.cgi?id=194437

Attachment 363171: Patch

https://bugs.webkit.org/attachment.cgi?id=363171&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363171
  --> https://bugs.webkit.org/attachment.cgi?id=363171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363171&action=review

rs=me

>
LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:24
> +	   delete pc.onicecandidate;

Just set it to null instead of delete?


More information about the webkit-reviews mailing list