[webkit-reviews] review granted: [Bug 195060] Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion : [Attachment 362999] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 28 12:41:17 PST 2019
Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195060: Web Inspector: Canvas: enabling auto-capture if the frame count is
empty triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=195060
Attachment 362999: Patch
https://bugs.webkit.org/attachment.cgi?id=362999&action=review
--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 362999
--> https://bugs.webkit.org/attachment.cgi?id=362999
Patch
r=me, nice refactor. It makes much more sense to check
this._recordingAutoCaptureFrameCountInputElementValue separately from setting
the frame count and updating the label.
More information about the webkit-reviews
mailing list