[webkit-reviews] review granted: [Bug 194796] Web Inspector: Styles: Control-Space should force completion : [Attachment 363042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 12:35:18 PST 2019

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194796: Web Inspector: Styles: Control-Space should force completion

Attachment 363042: Patch


--- Comment #20 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 363042
  --> https://bugs.webkit.org/attachment.cgi?id=363042

View in context: https://bugs.webkit.org/attachment.cgi?id=363042&action=review


> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:379
> +	   const options = {allowEmptyPrefix: forceCompletions};

This can be inlined:

let {completions, prefix} = this._completionProvider(valueWithoutSuggestion,
{allowEmptyPrefix: forceCompletions});

More information about the webkit-reviews mailing list