[webkit-reviews] review granted: [Bug 195172] [ContentChangeObserver] Introduce observer subclasses to scope content change observing. : [Attachment 363237] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 11:10:41 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195172: [ContentChangeObserver] Introduce observer subclasses to scope
content change observing.
https://bugs.webkit.org/show_bug.cgi?id=195172

Attachment 363237: Patch

https://bugs.webkit.org/attachment.cgi?id=363237&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363237
  --> https://bugs.webkit.org/attachment.cgi?id=363237
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363237&action=review

> Source/WebCore/dom/Document.cpp:2058
> +    ContentChangeObserver::StyleRecalcObserver observer(page());

observingScope?

> Source/WebCore/page/ios/ContentChangeObserver.h:53
> +    class StyleChangeObserver {

StyleChangeScope


More information about the webkit-reviews mailing list