[webkit-reviews] review granted: [Bug 195107] Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap : [Attachment 363226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 10:19:37 PST 2019

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 195107: Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap

Attachment 363226: Patch


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 363226
  --> https://bugs.webkit.org/attachment.cgi?id=363226

View in context: https://bugs.webkit.org/attachment.cgi?id=363226&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2788
> +    } while (clientWidth != expectedClientWidth);

Having a maximum number of tries would help us debug any future problems with
this, turning a timeout into an eventual failure.  Right now the maximum is
effectively 1, and this patch makes it infinite.  Somewhere between the two
ought to be good.

More information about the webkit-reviews mailing list