[webkit-reviews] review denied: [Bug 191645] [Curl] Implement Cookie Accept Policy. : [Attachment 363211] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 05:53:36 PST 2019

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 191645: [Curl] Implement Cookie Accept Policy.

Attachment 363211: Patch


--- Comment #56 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 363211
  --> https://bugs.webkit.org/attachment.cgi?id=363211

View in context: https://bugs.webkit.org/attachment.cgi?id=363211&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:390
>      pstmt->bindText(4, requestHost);

Is this right to specify 'requestHost'?
For example, you visited "http://host1.example.com", that response set a cookie
with 'Domain=example.com' parameter.
Then, you visit "http://example.com".
In this time you should send the cookie. However SQL query is:
domain = host1.example.com OR domain GLOB "*.example.com"
this query doesn't match "example.com".

More information about the webkit-reviews mailing list