[webkit-reviews] review granted: [Bug 195127] The parser is failing to record the token location of new in new.target. : [Attachment 363177] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 20:58:03 PST 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195127: The parser is failing to record the token location of new in
new.target.
https://bugs.webkit.org/show_bug.cgi?id=195127

Attachment 363177: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=363177&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 363177
  --> https://bugs.webkit.org/attachment.cgi?id=363177
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363177&action=review

r=me

> Source/JavaScriptCore/parser/Parser.cpp:-4734
> -		   JSTokenLocation location(tokenLocation());

If it is not difficult, can we have a test for this?


More information about the webkit-reviews mailing list