[webkit-reviews] review granted: [Bug 194959] Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories : [Attachment 363163] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 27 18:11:19 PST 2019
Chris Dumez <cdumez at apple.com> has granted review:
Bug 194959: Flaky API Test:
TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
https://bugs.webkit.org/show_bug.cgi?id=194959
Attachment 363163: Patch
https://bugs.webkit.org/attachment.cgi?id=363163&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 363163
--> https://bugs.webkit.org/attachment.cgi?id=363163
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=363163&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1376
> + TestWebKitAPI::Util::spinRunLoop(1);
1 second seems excessive, I would suggest 0.1
More information about the webkit-reviews
mailing list