[webkit-reviews] review granted: [Bug 195136] Web Inspector: Canvas: change tests to not print out dataURLs : [Attachment 363165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 17:43:15 PST 2019

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195136: Web Inspector: Canvas: change tests to not print out dataURLs

Attachment 363165: Patch


--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 363165
  --> https://bugs.webkit.org/attachment.cgi?id=363165

View in context: https://bugs.webkit.org/attachment.cgi?id=363165&action=review

r=me, nice change.

> LayoutTests/inspector/canvas/requestContent-2d.html:28
> +	       .then(({content}) =>
"data:image/png;base64,".length, "The content should not be empty."))

I'd drop the article from all of these: "Content should not be empty."

> LayoutTests/inspector/canvas/setShaderProgramHighlighted-expected.txt:12
> +PASS: Unhighlighting a shader program should draw differently.

Can this just be "Unhighlighting a shader program should change the content",
or does the distinction matter?

More information about the webkit-reviews mailing list