[webkit-reviews] review granted: [Bug 195047] [ews-app] Update method to save build to handle builder_display_name : [Attachment 362983] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 27 15:19:08 PST 2019
dewei_zhu at apple.com has granted Aakash Jain <aakash_jain at apple.com>'s request
for review:
Bug 195047: [ews-app] Update method to save build to handle
builder_display_name
https://bugs.webkit.org/show_bug.cgi?id=195047
Attachment 362983: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=362983&action=review
--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 362983
--> https://bugs.webkit.org/attachment.cgi?id=362983
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362983&action=review
> Tools/BuildSlaveSupport/ews-app/ews/views/results.py:81
> + 'number', 'result',
'state_string', 'started_at', 'complete_at'],
Nit: we need a consistent indentation. Usually 4 spaces.
More information about the webkit-reviews
mailing list