[webkit-reviews] review granted: [Bug 173747] Web Inspector: Use Element.closest for internal code : [Attachment 363127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 15:12:23 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173747: Web Inspector: Use Element.closest for internal code
https://bugs.webkit.org/show_bug.cgi?id=173747

Attachment 363127: Patch

https://bugs.webkit.org/attachment.cgi?id=363127&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363127
  --> https://bugs.webkit.org/attachment.cgi?id=363127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363127&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:2340
> +	   let contentBrowserElement =
this.currentFocusElement.closest("content-browser");

This should be ".content-browser"


More information about the webkit-reviews mailing list