[webkit-reviews] review granted: [Bug 195018] Web Inspector: Dark Mode: unreadable text in bezier curve editor numeric input fields : [Attachment 363109] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195018: Web Inspector: Dark Mode: unreadable text in bezier curve editor
numeric input fields
https://bugs.webkit.org/show_bug.cgi?id=195018

Attachment 363109: Patch

https://bugs.webkit.org/attachment.cgi?id=363109&action=review




--- Comment #6 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 363109
  --> https://bugs.webkit.org/attachment.cgi?id=363109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363109&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:-139
>> -	box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);
> 
> You changed the style of the inputs. They look fine but it would be nice to
mention it in the changelog because I could've missed it.

It's a simple enough patch, but I agree that only mentioning the clean-up and
not the main fix is confusing.