[webkit-reviews] review granted: [Bug 195101] Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled : [Attachment 363097] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 195101: Unable to log into chase.com on iPad when DeviceMotionEvent API is
disabled
https://bugs.webkit.org/show_bug.cgi?id=195101

Attachment 363097: Patch

https://bugs.webkit.org/attachment.cgi?id=363097&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 363097
  --> https://bugs.webkit.org/attachment.cgi?id=363097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review

r=me with one change

> Source/WebCore/page/DOMWindow.cpp:1894
> +    if (!isSameSecurityOriginAsMainFrame() || !isSecureContext())
> +	   return;

Can you add a test for needsSiteSpecificQuirks here, so that website developers
can disable the quirk when testing a fix?