[webkit-reviews] review granted: [Bug 195056] Remove UserMediaProcessManager processState map : [Attachment 363022] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 195056: Remove UserMediaProcessManager processState map
https://bugs.webkit.org/show_bug.cgi?id=195056

Attachment 363022: Patch

https://bugs.webkit.org/attachment.cgi?id=363022&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 363022
  --> https://bugs.webkit.org/attachment.cgi?id=363022
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363022&action=review

> Source/WebKit/ChangeLog:9
> +	   To improve on this model, this patch doing the following:

Nit: "this patch doing the following:" -> "this patch does the following:"

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:64
> +static HashSet<UserMediaPermissionRequestManagerProxy*>& proxies()
> +{
> +    static NeverDestroyed<HashSet<UserMediaPermissionRequestManagerProxy*>>
set;
> +    return set;
> +}
> +
> +void UserMediaPermissionRequestManagerProxy::forEach(const
WTF::Function<void(UserMediaPermissionRequestManagerProxy&)>& function)
> +{
> +    for (auto* proxy : proxies())
> +	   function(*proxy);
> +}

Nit: this should be in "#if ENABLE(MEDIA_STREAM)".