[webkit-reviews] review granted: [Bug 195064] Web Automation: cannot find nested iframe elements using Find Elements command : [Attachment 363017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 13:57:17 PST 2019


Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 195064: Web Automation: cannot find nested iframe elements using Find
Elements command
https://bugs.webkit.org/show_bug.cgi?id=195064

Attachment 363017: Patch

https://bugs.webkit.org/attachment.cgi?id=363017&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363017
  --> https://bugs.webkit.org/attachment.cgi?id=363017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363017&action=review

rs=me

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:112
> +	   if (value instanceof Array)

Should we also have an `instanceof Object` case?


More information about the webkit-reviews mailing list