[webkit-reviews] review granted: [Bug 195049] Fix warnings on ARM and MIPS : [Attachment 362986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 12:32:51 PST 2019


Mark Lam <mark.lam at apple.com> has granted Dominik Inf├╝hr
<dinfuehr at igalia.com>'s request for review:
Bug 195049: Fix warnings on ARM and MIPS
https://bugs.webkit.org/show_bug.cgi?id=195049

Attachment 362986: Patch

https://bugs.webkit.org/attachment.cgi?id=362986&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362986
  --> https://bugs.webkit.org/attachment.cgi?id=362986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

r=me with fix.

> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
> +	       candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());

Let's use bitwise_cast here too.


More information about the webkit-reviews mailing list