[webkit-reviews] review granted: [Bug 195054] [iOS] Regression(PSON) Scroll position is no longer restored when navigating back to reddit.com : [Attachment 362991] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 195054: [iOS] Regression(PSON) Scroll position is no longer restored when
navigating back to reddit.com
https://bugs.webkit.org/show_bug.cgi?id=195054

Attachment 362991: Patch

https://bugs.webkit.org/attachment.cgi?id=362991&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 362991
  --> https://bugs.webkit.org/attachment.cgi?id=362991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362991&action=review

r=me

Can you file a follow-up Radar about the UIProcess vs WebProcess scroll
position mismatch on session restoration?

> Source/WebKit/ChangeLog:14
> +	   and would there get reloaded abd finish loading *after* the load
event.

=> would then get reloaded and

> Source/WebCore/page/MemoryRelease.cpp:88
> +	   MemoryCache::singleton().pruneLiveResourcesToSize(0,
/*shouldDestroyDecodedDataForAllLiveResources*/ true);

I'd prefer seeing "auto shouldDestroyDecodedDataForAllLiveResources = true;
pruneLiveResourcesToSize(0, shouldDestroyDecodedDataForAllLiveResources);".