[webkit-reviews] review granted: [Bug 194972] Web Inspector: CPU Usage Timeline - Main Thread Indicator : [Attachment 362964] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 00:21:21 PST 2019

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194972: Web Inspector: CPU Usage Timeline - Main Thread Indicator

Attachment 362964: [PATCH] Proposed Fix


--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362964
  --> https://bugs.webkit.org/attachment.cgi?id=362964
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=362964&action=review


I think this might need a rebase, as bugzilla wasn't able to apply it during
the review :(

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:221
> +Object.defineProperty(Node.prototype, "enclosingNodeOrSelfWithLocalName",

I agree with @Nikita.  I think we should fix the existing version, rather than
create a new one.

Considering that we `toUpperCase` the `nodeNames`, we should be able to just
`toLowerCase` the `node.nodeName` instead.

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:208
> +	  

This could use a more "specific" name, like

More information about the webkit-reviews mailing list