[webkit-reviews] review granted: [Bug 170631] Web Inspector: navigation sidebar says "No Search Results" when a slow search is in progress : [Attachment 361856] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 170631: Web Inspector: navigation sidebar says "No Search Results" when a
slow search is in progress
https://bugs.webkit.org/show_bug.cgi?id=170631

Attachment 361856: Patch

https://bugs.webkit.org/attachment.cgi?id=361856&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 361856
  --> https://bugs.webkit.org/attachment.cgi?id=361856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361856&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:272
> -		   DOMAgent.discardSearchResults(this._domSearchIdentifier);
> +		  
countPromise(DOMAgent.discardSearchResults(this._domSearchIdentifier));

We shouldn't need to wait on this one, it is just clearing old search data, not
affecting the current search(es).