[webkit-reviews] review requested: [Bug 192947] Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards : [Attachment 362945] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 192947: Web Inspector: Keyboard shortcut for settings tab too greedy on
non-US keyboards
https://bugs.webkit.org/show_bug.cgi?id=192947

Attachment 362945: Patch

https://bugs.webkit.org/attachment.cgi?id=362945&action=review




--- Comment #14 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 362945

  --> https://bugs.webkit.org/attachment.cgi?id=362945&action=review

Patch

I feel pretty strongly now that fixing this bug should be separate from
refactoring all uses of code/key/charCode/keyCode/keyIdentifier and potentially
introducing several regressions.