[webkit-reviews] review granted: [Bug 176810] for..in on a Proxy loops over non enumerable properties : [Attachment 362896] [JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 176810: for..in on a Proxy loops over non enumerable properties
https://bugs.webkit.org/show_bug.cgi?id=176810

Attachment 362896: [JSC] Filter DontEnum properties in
ProxyObject::getOwnPropertyNames()

https://bugs.webkit.org/attachment.cgi?id=362896&action=review




--- Comment #69 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362896
  --> https://bugs.webkit.org/attachment.cgi?id=362896
[JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

View in context: https://bugs.webkit.org/attachment.cgi?id=362896&action=review

r=me

> Source/WebCore/ChangeLog:15
> +	   This patch adds DontEnum filtering for ProxyObjects, however we
continue
> +	   to explicitly filter them in JSDOMConvertRecord, which needs to use
the
> +	   property descriptor after filtering. This change prevents observably
> +	   fetching the property descriptor twice per property.

Can you add tests for this?