[webkit-reviews] review granted: [Bug 185211] JavaScriptCore should throw TypeError if [[OwnPropertyKeys]] returns duplicate entries : [Attachment 362910] [JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 185211: JavaScriptCore should throw TypeError if [[OwnPropertyKeys]]
returns duplicate entries
https://bugs.webkit.org/show_bug.cgi?id=185211

Attachment 362910: [JSC] Filter DontEnum properties in
ProxyObject::getOwnPropertyNames()

https://bugs.webkit.org/attachment.cgi?id=362910&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362910
  --> https://bugs.webkit.org/attachment.cgi?id=362910
[JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

View in context: https://bugs.webkit.org/attachment.cgi?id=362910&action=review

r=me

> Source/JavaScriptCore/runtime/ProxyObject.cpp:955
> +	   // keys filtered by type).

nit: I'd link to the spec here since you're referencing it.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:962
> +	   if (!(type & resultFilter))
> +	       return dontExitEarly;

Can a test be added for the observability of calling toPropertyKey before this
branch?