[webkit-reviews] review granted: [Bug 190138] AX: <footer> HTML5 tag not reading as ARIA Landmark to VoiceOver : [Attachment 362886] patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 190138: AX: <footer> HTML5 tag not reading as ARIA Landmark to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=190138

Attachment 362886: patch

https://bugs.webkit.org/attachment.cgi?id=362886&action=review




--- Comment #21 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> ---
Comment on attachment 362886
  --> https://bugs.webkit.org/attachment.cgi?id=362886
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362886&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2871
> +	   if (!isDescendantOfElementType({ articleTag, sectionTag, mainTag,
blockquoteTag, detailsTag, fieldsetTag, figureTag, tdTag }))

BTW (for a new/separate bug): Headers fall into the very same mapping pattern.
See https://w3c.github.io/html-aam/#el-header-ancestorbody versus
https://w3c.github.io/html-aam/#el-header.