[webkit-reviews] review requested: [Bug 194961] [ews-app] Remove BuilderMapping table : [Attachment 362909] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 10:17:55 PST 2019


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 194961: [ews-app] Remove BuilderMapping table
https://bugs.webkit.org/show_bug.cgi?id=194961

Attachment 362909: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=362909&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 362909

  --> https://bugs.webkit.org/attachment.cgi?id=362909&action=review

Proposed patch

> Can we add a bit more of a description here? Something along the lines of
'Store builder information with build, instead of referencing builder'
Done.

> I'd like to seem a bit more descriptive changelog, but other than that, looks
good to me.
Thanks


More information about the webkit-reviews mailing list