[webkit-reviews] review granted: [Bug 194975] [JSC] Lazily create sentinel Map and Set buckets : [Attachment 362820] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194975: [JSC] Lazily create sentinel Map and Set buckets
https://bugs.webkit.org/show_bug.cgi?id=194975

Attachment 362820: Patch

https://bugs.webkit.org/attachment.cgi?id=362820&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362820
  --> https://bugs.webkit.org/attachment.cgi?id=362820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:404
> +    // Eagerly initialize constant cells if concurrent compiler can touch.

“if” => “since”. “touch” => “access them”

> Source/JavaScriptCore/runtime/VM.h:572
> +    JSCell* sentinelSetBucketSlow();

Should be private

> Source/JavaScriptCore/runtime/VM.h:580
> +    JSCell* sentinelMapBucketSlow();

Ditto