[webkit-reviews] review granted: [Bug 194973] Have a single notion of scroll position in the scrolling tree and derive layoutViewport from it : [Attachment 362809] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 194973: Have a single notion of scroll position in the scrolling tree and
derive layoutViewport from it
https://bugs.webkit.org/show_bug.cgi?id=194973

Attachment 362809: Patch

https://bugs.webkit.org/attachment.cgi?id=362809&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 362809
  --> https://bugs.webkit.org/attachment.cgi?id=362809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362809&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:63
> +    FloatPoint scrollPosition() const { return m_scrollPosition; }

As discussed, it would be good to clarify in naming this is the current scroll
position (here and elsewhere).