[webkit-reviews] review granted: [Bug 194954] Regression(PSON) Unable to preview password-protected documents on iCloud.com : [Attachment 362745] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 194954: Regression(PSON) Unable to preview password-protected documents on
iCloud.com
https://bugs.webkit.org/show_bug.cgi?id=194954

Attachment 362745: Patch

https://bugs.webkit.org/attachment.cgi?id=362745&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 362745
  --> https://bugs.webkit.org/attachment.cgi?id=362745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362745&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1167
> +    pageClient().requestPasswordForQuickLookDocument(fileName,
[protectedThis = makeRef(*this), process = WTFMove(process)](const String&
password) {

I'm not sure you would need to protect this here.